Changeset 166 for trunk/grails-app/controllers

Timestamp:

Oct 26, 2009, 3:11:18 PM (15 years ago)

Author:

gav

Message:

Add test and message for no granted authority to LoginController.
Correct belongsTo in Person-PersonGroup? relationship.
Re-generate PersonGroup? controller and views.
Add more help balloon messages for Person and Task.
Default ROLE_AppUser to ON when creating a person.

Location:

trunk/grails-app/controllers

Files:

• LoginController.groovy (modified) (2 diffs)
• PersonGroupController.groovy (modified) (2 diffs)

trunk/grails-app/controllers/LoginController.groovy

@@ -144 +144 @@
                 def username = session[AuthenticationProcessingFilter.SPRING_SECURITY_LAST_USERNAME_KEY]
                 def msg = ''
+        def person = Person.findByLoginName(username)
                 def exception = session[AbstractProcessingFilter.SPRING_SECURITY_LAST_EXCEPTION_KEY]
                 if (exception) {
@@ -149 +150 @@
                                 msg = "[$username] is disabled."
                         }
+            else if (person.authorities.isEmpty()) {
+                msg = "[$username] has no GrantedAuthority."
+            }
                         else {
                                 msg = "[$username] wrong username/password."

trunk/grails-app/controllers/PersonGroupController.groovy

@@ -27 +27 @@
         if(personGroupInstance) {
             try {
-                personGroupInstance.delete()
+                personGroupInstance.delete(flush:true)
                 flash.message = "PersonGroup ${params.id} deleted"
                 redirect(action:list)
@@ -77 +77 @@
         else {
             flash.message = "PersonGroup not found with id ${params.id}"
-            redirect(action:edit,id:params.id)
+            redirect(action:list)
         }
     }